> On May 15, 2014, 11:04 p.m., Maxim Khutornenko wrote: > > build.gradle, line 235 > > <https://reviews.apache.org/r/21455/diff/1/?file=581766#file581766line235> > > > > How about a custom target instead? Having something like "gradle > > build_cq" would be easier to remember for use outside of jenkins script.
agree, think having these tied to a task would be better, maybe gradle verify since check is part of the lifecycle all ready - Jake ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21455/#review43177 ----------------------------------------------------------- On May 14, 2014, 8:31 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21455/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 8:31 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Inclusion of findbugs has had the side-effect of slowing down development > iteration. It makes sense to only perform code quality checks on-demand, so > we would typically do this in jenkins, before publishing a review diff, and > before pushing to master. > > > Diffs > ----- > > build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f > build.gradle f2c729e28b01c89e2130c48d2aa43d7c830528a5 > > Diff: https://reviews.apache.org/r/21455/diff/ > > > Testing > ------- > > Before this change: > > $ ./gradlew clean build > :clean > :about > :bootstrapThrift UP-TO-DATE > :generateSources > :compileGeneratedJava > :processGeneratedResources UP-TO-DATE > :generatedClasses > :compileJava > :processResources > :classes > :jar > :assemble > :checkstyleMain > :compileTestJava > :processTestResources > :testClasses > :checkstyleTest > :findbugsGenerated > :findbugsMain > :findbugsTest > :licenseGenerated UP-TO-DATE > :licenseMain UP-TO-DATE > :licenseTest UP-TO-DATE > :license UP-TO-DATE > :test > > BUILD SUCCESSFUL > > Total time: 9 mins 5.6 secs > > > After this change: > $ ./gradlew clean build > :clean > :about > :bootstrapThrift UP-TO-DATE > :generateSources > :compileGeneratedJava > :processGeneratedResources UP-TO-DATE > :generatedClasses > :compileJava > :processResources > :classes > :jar > :assemble > :checkstyleMain SKIPPED > :compileTestJava > :processTestResources > :testClasses > :checkstyleTest SKIPPED > :findbugsGenerated SKIPPED > :findbugsMain SKIPPED > :findbugsTest SKIPPED > :licenseGenerated SKIPPED > :licenseMain SKIPPED > :licenseTest SKIPPED > :license UP-TO-DATE > :test > > BUILD SUCCESSFUL > > Total time: 1 mins 41.661 secs > > > /gradlew -PrunCodeQuality=true clean build > Parallel execution is an incubating feature. > :clean > :about > :bootstrapThrift UP-TO-DATE > :generateSources > :compileGeneratedJava > :processGeneratedResources UP-TO-DATE > :generatedClasses > :compileJava > :processResources > :classes > :jar > :assemble > :checkstyleMain > :compileTestJava > :processTestResources > :testClasses > :checkstyleTest > :findbugsGenerated > :findbugsMain > :findbugsTest > :licenseGenerated UP-TO-DATE > :licenseMain UP-TO-DATE > :licenseTest UP-TO-DATE > :license UP-TO-DATE > :test > :jacocoTestReport > :check > :build > > BUILD SUCCESSFUL > > Total time: 6 mins 58.768 secs > > > Thanks, > > Bill Farner > >
