----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21455/#review43769 -----------------------------------------------------------
Ship it! Ship It! - Maxim Khutornenko On May 22, 2014, 7:46 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21455/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 7:46 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Inclusion of findbugs has had the side-effect of slowing down development > iteration. It makes sense to only perform code quality checks on-demand, so > we would typically do this in jenkins, before publishing a review diff, and > before pushing to master. > > > Diffs > ----- > > build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f > build.gradle d22038503a7bf894c335d8a446dbd936abf58516 > docs/developing-aurora-scheduler.md > 95bf47278b4cf040ed902e43a151fe9fae19bfc5 > > Diff: https://reviews.apache.org/r/21455/diff/ > > > Testing > ------- > > Before this change: > > $ ./gradlew clean build > :clean > :about > :bootstrapThrift UP-TO-DATE > :generateSources > :compileGeneratedJava > :processGeneratedResources UP-TO-DATE > :generatedClasses > :compileJava > :processResources > :classes > :jar > :assemble > :checkstyleMain > :compileTestJava > :processTestResources > :testClasses > :checkstyleTest > :findbugsGenerated > :findbugsMain > :findbugsTest > :licenseGenerated UP-TO-DATE > :licenseMain UP-TO-DATE > :licenseTest UP-TO-DATE > :license UP-TO-DATE > :test > > BUILD SUCCESSFUL > > Total time: 9 mins 5.6 secs > > > After this change: > $ ./gradlew clean build > :clean > :about > :bootstrapThrift UP-TO-DATE > :generateSources > :compileGeneratedJava > :processGeneratedResources UP-TO-DATE > :generatedClasses > :compileJava > :processResources > :classes > :jar > :assemble > :checkstyleMain SKIPPED > :compileTestJava > :processTestResources > :testClasses > :checkstyleTest SKIPPED > :findbugsGenerated SKIPPED > :findbugsMain SKIPPED > :findbugsTest SKIPPED > :licenseGenerated SKIPPED > :licenseMain SKIPPED > :licenseTest SKIPPED > :license UP-TO-DATE > :test > > BUILD SUCCESSFUL > > Total time: 1 mins 41.661 secs > > > /gradlew -PrunCodeQuality=true clean build > Parallel execution is an incubating feature. > :clean > :about > :bootstrapThrift UP-TO-DATE > :generateSources > :compileGeneratedJava > :processGeneratedResources UP-TO-DATE > :generatedClasses > :compileJava > :processResources > :classes > :jar > :assemble > :checkstyleMain > :compileTestJava > :processTestResources > :testClasses > :checkstyleTest > :findbugsGenerated > :findbugsMain > :findbugsTest > :licenseGenerated UP-TO-DATE > :licenseMain UP-TO-DATE > :licenseTest UP-TO-DATE > :license UP-TO-DATE > :test > :jacocoTestReport > :check > :build > > BUILD SUCCESSFUL > > Total time: 6 mins 58.768 secs > > > Thanks, > > Bill Farner > >
