> On April 25, 2014, 4:06 a.m., Bill Farner wrote: > > I have some reservations with this, but they're not well-formed. I like > > the idea of giving committers a chance to chime in on reviews, and we seem > > to be building process around reviewboard for that. We also have plans to > > build test automation around reviewboard. This seems to turn github into a > > "back door" of sorts for changes to not receive the same level of scrutiny. > > What are your thoughts?
Github makes it easier for some to contribute patches, but we should require the same criteria as we do with reviewboard (Jira ticket, tests performed, etc). This tooling is just to make it easier for us to manage those contributions, wish we could disable Github pull requests on the mirrors, but that is not an available option - Jake ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20407/#review41435 ----------------------------------------------------------- On April 17, 2014, 4 a.m., Jake Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20407/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 4 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-323 > https://issues.apache.org/jira/browse/AURORA-323 > > > Repository: aurora > > > Description > ------- > > AURORA-323:Add ability to merge in github pull requests similar to rbt > > Created a new extension for rbt which adds a new github subcommand to preview > and > merge/commit available pull requests. Adds text to the commit message > so when github mirrors the given commit the pull request will automatically > be closed. > > > Diffs > ----- > > .reviewboardrc a66e6fd0da9102f760381401b56b41b29c8d6f4d > rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 > > Diff: https://reviews.apache.org/r/20407/diff/ > > > Testing > ------- > > Preview a pull request patch > ./rbt github -p 7 > > Commit a pull request > ./rbt github -c 7 > > > Thanks, > > Jake Farrell > >
