> On May 21, 2014, 2:58 a.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java, 
> > line 135
> > <https://reviews.apache.org/r/21383/diff/4-5/?file=584804#file584804line135>
> >
> >     remove trailing WS.
> >     
> >     this should be trivial to catch in checkstyle, i'll kick out a review 
> > shortly to do just that

Hm, it actually is caught by checkstyle.  A quick test yielded:

[ant:checkstyle] 
/Users/bill/code/aurora/src/main/java/org/apache/aurora/scheduler/thrift/auth/DecoratedThrift.java:16:
 Line has trailing spaces.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21383/#review43575
-----------------------------------------------------------


On May 20, 2014, 10:56 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21383/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 10:56 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: aurora-417
>     https://issues.apache.org/jira/browse/aurora-417
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add cron schedule and deschedule calls to the scheduler API.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> d377974da4f7efa7f47e06702654bc786299e01c 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  4386a86c0aebdb9666c0232672f8c1bab7458f47 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2beb9a0112459f9b1dddc64e8a7563f96f4c397f 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 66292dc0369941fc62719d49209edc07adc81a53 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2142f116afffdbd9acb63b835c240f03f417c511 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 933a56bf3f7165fa84aedcc8d1392e32824fd487 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 399d4c614dda93ae0e7d8f38a02379bc0f42e4af 
> 
> Diff: https://reviews.apache.org/r/21383/diff/
> 
> 
> Testing
> -------
> 
> Ran all tests with gradlew; no errors. (Includes two new tests, that ensure 
> that calling the new APIs causes the right internal cron methods to be 
> called.)
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to