> On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/maintenance.py, line 72
> > <https://reviews.apache.org/r/22167/diff/3/?file=603316#file603316line72>
> >
> >     This help line is unclear: what does "time interval for the percentage 
> > of up tasks" mean?  The time period over which a certain percentage of 
> > tasks must have been up all the time? Time period over which a percentage 
> > of tasks must have been up for at least some amount of time?
> >
> 
> Maxim Khutornenko wrote:
>     The override comments here are intentionally vague to discourage their 
> use :) Whoever is trying to override them must already have an intimate 
> knowledge of admin sla_* commands providing, hopefully, clear instructions.
> 
> Mark Chu-Carroll wrote:
>     Ah, I didn't realize that. Maybe even be explicit about it: "Don't change 
> this unless you're an expert". Although that would probably actually 
> encourage people!

Makes sense. Hardened help comments :) 


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45131
-----------------------------------------------------------


On June 9, 2014, 10:08 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 10:08 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
> 
> 
> Bugs: AURORA-445
>     https://issues.apache.org/jira/browse/AURORA-445
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding SLA check into perform_maintenance_hosts command with the possibility 
> of override.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/BUILD 
> 8d850bcea353a0a4afe0135d600a890511bb6751 
>   src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> f223c5e90871d6f49f68fd0a93030ec785ad2c95 
>   src/main/python/apache/aurora/client/base.py 
> 6716ba642500dca0aea241d94d85a33359bfd746 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 4e018f14a4f45cfaf614d4c6e434dea6230a95c1 
>   src/main/python/apache/aurora/client/commands/BUILD 
> 03cd4855464972e4ace6081f50d140ffbe5807c4 
>   src/main/python/apache/aurora/client/commands/admin.py 
> a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa 
>   src/main/python/apache/aurora/client/commands/maintenance.py 
> e4d60d47280ad6e18fff7f4b0d916b97c2f098f7 
>   src/test/python/apache/aurora/client/commands/test_admin_sla.py 
> da8015ff417fb87a38b87964d9aa21d572a90a70 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> dd56b8d1feddb48a741e1a855833eb577cea67ab 
>   src/test/python/apache/aurora/client/commands/util.py 
> 84784171816797f3a4fa4c5238d19b626e68ff44 
> 
> Diff: https://reviews.apache.org/r/22167/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/tests/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to