> On June 20, 2014, 5:30 p.m., Brian Wickman wrote: > > not a big fan of globals here. can you instead annotate the context with > > the exception and in post-dispatch have the plugin print it out if > > --reveal-errors is set?
I'm not a big fan of globals either, but I'm concerned about depending on the context in a, well, context where it's possible that the context is messed up or doesn't exist. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46325 ----------------------------------------------------------- On June 20, 2014, 4:47 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22839/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 4:47 p.m.) > > > Review request for Aurora, David McLaughlin and Brian Wickman. > > > Bugs: aurora-544 and aurora-545 > https://issues.apache.org/jira/browse/aurora-544 > https://issues.apache.org/jira/browse/aurora-545 > > > Repository: aurora > > > Description > ------- > > Add configuration plugins to default aurora client. > > - Add a plugin to allow users to set logging levels. > - Add a plugin to allow users to configure whether or not unknown exceptions > get > caught or revealed. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > 827bbb88230f4e536500710695cb92bf39da3447 > src/main/python/apache/aurora/client/cli/standalone_client.py > 5d1a4a53a8b36b6dd072485260d490435da6968d > src/test/python/apache/aurora/client/cli/test_plugins.py > ce85318727dcaf22a696d05f99c49b5e953bd3ca > > Diff: https://reviews.apache.org/r/22839/diff/ > > > Testing > ------- > > - Added new test. > - Ran all unit tests. > - Did manual command-line testing. > > > Thanks, > > Mark Chu-Carroll > >
