----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46778 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/standalone_client.py <https://reviews.apache.org/r/22839/#comment82359> No. We don't want to catch an invalid parameter like "--logging-level-max". - Mark Chu-Carroll On June 25, 2014, 12:38 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22839/ > ----------------------------------------------------------- > > (Updated June 25, 2014, 12:38 p.m.) > > > Review request for Aurora, David McLaughlin and Brian Wickman. > > > Bugs: aurora-544 and aurora-545 > https://issues.apache.org/jira/browse/aurora-544 > https://issues.apache.org/jira/browse/aurora-545 > > > Repository: aurora > > > Description > ------- > > Add configuration plugins to default aurora client. > > - Add a plugin to allow users to set logging levels. > - Add a plugin to allow users to configure whether or not unknown exceptions > get > caught or revealed. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > 827bbb88230f4e536500710695cb92bf39da3447 > src/main/python/apache/aurora/client/cli/standalone_client.py > 5d1a4a53a8b36b6dd072485260d490435da6968d > src/test/python/apache/aurora/client/cli/test_config_noun.py > c55c9fee230002ef749965eb559ee5b309ee143b > src/test/python/apache/aurora/client/cli/test_create.py > b9313be657ebaf9c79a7695b75abe2d90a7d75dd > src/test/python/apache/aurora/client/cli/test_plugins.py > ce85318727dcaf22a696d05f99c49b5e953bd3ca > src/test/python/apache/aurora/client/cli/util.py > a2c9d09c58243250baefab20000ee51f5ea3b411 > > Diff: https://reviews.apache.org/r/22839/diff/ > > > Testing > ------- > > - Added new test. > - Ran all unit tests. > - Did manual command-line testing. > > > Thanks, > > Mark Chu-Carroll > >
