> On July 31, 2014, 10:06 p.m., David McLaughlin wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 561 > > <https://reviews.apache.org/r/24116/diff/3/?file=647049#file647049line561> > > > > This needs everything we know about the update to be returned (e.g. > > UpdateConfiguration and UpdateSettings). We'll want to show all this info > > in the UI. > > Maxim Khutornenko wrote: > I thought we specifically did not want to return any TaskConfig data to > the UI? What are you trying to pull from UpdateConfiguration?
At the very least we would need JobKey. I thought TaskConfig would be useful when looking at historical updates, since the job will only ever show the current configurations. > On July 31, 2014, 10:06 p.m., David McLaughlin wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 572 > > <https://reviews.apache.org/r/24116/diff/3/?file=647049#file647049line572> > > > > Can we add pagination to this? > > Maxim Khutornenko wrote: > Do you really need it now? How about adding it when we really feel the > need? I don't expect the amount of data would ever be a problem here. I think part of this work will be a view showing the list of the latest update events across the whole scheduler in the last X minutes/hours/days. I think we can easily imagine the working set there being in the thousands of updates and client-side pagination not being feasible. Since we already saw performance become an issue with client side pagination, I'd rather just implement this with scale in mind upfront. Right now it's also not clear to me how data will be sorted when it is returned. We might actually need another endpoint for this. I'm happy to punt on this until I have UI mockups to show. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49294 ----------------------------------------------------------- On July 31, 2014, 6:37 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24116/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 6:37 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-611 > https://issues.apache.org/jira/browse/AURORA-611 > > > Repository: aurora > > > Description > ------- > > First stab at update APIs. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 12de5a3e9e3aae217b30c385e2d7ec7b43863ae2 > src/main/thrift/org/apache/aurora/gen/api.thrift > 54b8985971719247a5d42d8676075a51045bbb92 > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > 2ea4a9ba0a1ea81fea5c4f5203457aa79ae67c10 > > Diff: https://reviews.apache.org/r/24116/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > >
