----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49387 -----------------------------------------------------------
This looks great, comments are ~all minor, we're very close to a +1 from me. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/24116/#comment86426> throw new UnsupportedOperationException("Not implemented"); here and elsewhere src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86429> once all reviewers like the shape of things, please come back to doc the struct fields. src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86427> I wonder if we should use this opportunity to choose a name that does not imply batching. maxSimultaneousInstances? updateGroupSize? I'm hope to ideas. Anybody else have an opinion? We don't need to dwell on this. src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86428> maxPerInstanceFailures? "total" to me suggests the "global counter", which i think we should avoid src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86432> how would you feel about a closed range instead of a set? i think this improves API ergonomics, matches the use cases we know of, and doesn't break any use case. src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86431> space before open brace src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86433> avoid introducing the new noun "deploy" src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86434> don't use a set, otherwise it begs the question why the others aren't all multi-value as well. - Bill Farner On Aug. 1, 2014, 9:40 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24116/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 9:40 p.m.) > > > Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-611 > https://issues.apache.org/jira/browse/AURORA-611 > > > Repository: aurora > > > Description > ------- > > First stab at update APIs. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 12de5a3e9e3aae217b30c385e2d7ec7b43863ae2 > src/main/thrift/org/apache/aurora/gen/api.thrift > 54b8985971719247a5d42d8676075a51045bbb92 > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > 2ea4a9ba0a1ea81fea5c4f5203457aa79ae67c10 > > Diff: https://reviews.apache.org/r/24116/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > >
