----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/#review49487 -----------------------------------------------------------
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql <https://reviews.apache.org/r/24243/#comment86555> Please prefix tables with job_ where appropriate. src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql <https://reviews.apache.org/r/24243/#comment86561> REFERENCES update_statuses(id) src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql <https://reviews.apache.org/r/24243/#comment86564> What's the motivation behind separating updates, update_configs, and update_settings? They seem tightly-coupled enough that they might benefit from being combined. src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql <https://reviews.apache.org/r/24243/#comment86562> What's this for? src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql <https://reviews.apache.org/r/24243/#comment86563> I'm an anti-fan of flags that say "do not do X", as they can lead to confusing double-negatives. Consider s/do_not_// - Bill Farner On Aug. 4, 2014, 6:02 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24243/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 6:02 p.m.) > > > Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-612 > https://issues.apache.org/jira/browse/AURORA-612 > > > Repository: aurora > > > Description > ------- > > DB tables for the job update store. Sending out early to solicit feedback > before moving to mappers. > > > Diffs > ----- > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > 5358b45102f53eea97a1ca709ba9375daa91a3ef > > Diff: https://reviews.apache.org/r/24243/diff/ > > > Testing > ------- > > > Thanks, > > Maxim Khutornenko > >
