> On Aug. 4, 2014, 8:31 p.m., Kevin Sweeney wrote:
> > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines 
> > 101-102
> > <https://reviews.apache.org/r/24243/diff/1/?file=650526#file650526line101>
> >
> >     Is there a reason not to use TIMESTAMP [1] types that will be 
> > translated to a JDBC Timestamp [2] type here?
> >     
> >     [1] http://www.h2database.com/html/datatypes.html#timestamp_type
> >     [2] http://docs.oracle.com/javase/7/docs/api/java/sql/Timestamp.html

The most likely use case for these would be the scheduler UI. I doubt java side 
would benefit from anything more complex than Long here (aside from extra 
validation). Also, the precedent is already set in locks table. 


> On Aug. 4, 2014, 8:31 p.m., Kevin Sweeney wrote:
> > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line 
> > 111
> > <https://reviews.apache.org/r/24243/diff/1/?file=650526#file650526line111>
> >
> >     Will the interface return RangeSet<Integer>? Maybe a more compact form 
> > could be used on disk as well.

Most likely. I can't see a more compact way on the SQL side though (given the 
existing H2 type set) without introducing more tables.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24243/#review49492
-----------------------------------------------------------


On Aug. 4, 2014, 8:28 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24243/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 8:28 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-612
>     https://issues.apache.org/jira/browse/AURORA-612
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> DB tables for the job update store. Sending out early to solicit feedback 
> before moving to mappers.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 5358b45102f53eea97a1ca709ba9375daa91a3ef 
> 
> Diff: https://reviews.apache.org/r/24243/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to