> On Aug. 3, 2014, 7:33 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/strategy/ActiveLimitedStrategy.java, > > line 50 > > <https://reviews.apache.org/r/24206/diff/1/?file=649183#file649183line50> > > > > typo
fixed > On Aug. 3, 2014, 7:33 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/strategy/QueueStrategy.java, > > line 18 > > <https://reviews.apache.org/r/24206/diff/1/?file=649185#file649185line18> > > > > Missing class comments explaining the meaning? fixed > On Aug. 3, 2014, 7:33 p.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/updater/strategy/BatchStrategyTest.java, > > line 50 > > <https://reviews.apache.org/r/24206/diff/1/?file=649187#file649187line50> > > > > typo Fixed, also convinced intellij to start flagging these again. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24206/#review49435 ----------------------------------------------------------- On Aug. 2, 2014, 5:20 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24206/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2014, 5:20 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-613 > https://issues.apache.org/jira/browse/AURORA-613 > > > Repository: aurora > > > Description > ------- > > The JobUpdater will call on an UpdateStrategy to determine how a job update > progresses through instances. This will remain a code island until the > surrounding features are filled in. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/updater/strategy/ActiveLimitedStrategy.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/updater/strategy/BatchStrategy.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/updater/strategy/QueueStrategy.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/updater/strategy/UpdateStrategy.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/updater/strategy/BatchStrategyTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/updater/strategy/QueueStrategyTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/24206/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > > Thanks, > > Bill Farner > >