> On Aug. 11, 2014, 4:18 p.m., Bill Farner wrote: > > Issue points out lack of test coverage, can you add that with the fix?
Sure. I think for this, it makes sense to put it in end-to-end. (unit tests in the client focus on verifying that API calls got made correctly; this seems more like a system-behavior test like what we do in the e2e.) - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/#review50224 ----------------------------------------------------------- On Aug. 11, 2014, 4:12 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24573/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 4:12 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: aurora-642 > https://issues.apache.org/jira/browse/aurora-642 > > > Repository: aurora > > > Description > ------- > > Inspect was using context.print_out() to add blank lines, but the > print_out method takes a mandatory string parameter. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/jobs.py > 3cb39b232648d69615bbdfedc4d81eaf7ece7938 > > Diff: https://reviews.apache.org/r/24573/diff/ > > > Testing > ------- > > > Thanks, > > Mark Chu-Carroll > >
