----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/#review50583 -----------------------------------------------------------
src/test/python/apache/aurora/client/cli/BUILD <https://reviews.apache.org/r/24573/#comment88445> -2 indent, remove extra newline after src/test/python/apache/aurora/client/cli/test_inspect.py <https://reviews.apache.org/r/24573/#comment88450> missing license header src/test/python/apache/aurora/client/cli/test_inspect.py <https://reviews.apache.org/r/24573/#comment88446> Leave no TODO unassigned: TODO(markcc) src/test/python/apache/aurora/client/cli/test_inspect.py <https://reviews.apache.org/r/24573/#comment88447> remove? src/test/python/apache/aurora/client/cli/test_inspect.py <https://reviews.apache.org/r/24573/#comment88448> remove comment? src/test/python/apache/aurora/client/cli/test_kill.py <https://reviews.apache.org/r/24573/#comment88449> revert? shouldn't classes be separated by 2 blank lines? - Bill Farner On Aug. 13, 2014, 7:27 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24573/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 7:27 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: aurora-642 > https://issues.apache.org/jira/browse/aurora-642 > > > Repository: aurora > > > Description > ------- > > Inspect was using context.print_out() to add blank lines, but the > print_out method takes a mandatory string parameter. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > 08590d0895a2b4082c6929a261b36c8a1a82ac97 > src/main/python/apache/aurora/client/cli/jobs.py > 3cb39b232648d69615bbdfedc4d81eaf7ece7938 > src/test/python/apache/aurora/client/cli/BUILD > 3c88ed7cf9f654bbbd80d1d44aa1dd1c8655e378 > src/test/python/apache/aurora/client/cli/test_inspect.py PRE-CREATION > src/test/python/apache/aurora/client/cli/test_kill.py > ee64908855a4960f44ce96c810e69dd105d2ce5d > src/test/python/apache/aurora/client/cli/util.py > 5d2e72d9a475cbb7821ca466d13c195d5eb942c1 > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > ea5ae8d0004aea42b7e750eb52c34a636e3a7998 > > Diff: https://reviews.apache.org/r/24573/diff/ > > > Testing > ------- > > > Thanks, > > Mark Chu-Carroll > >
