-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/#review50692
-----------------------------------------------------------


Also, while it might seem tedious, can you include in the description the 
events you would expect for the success and failure (revert) cases of:

1. instance update
2. instance remove
3. instance add
4. noop

This will help prove the enum is complete, and help me follow the same policy 
when implementing the backend.

- Bill Farner


On Aug. 14, 2014, 11:21 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24720/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 11:21 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added some more items to the JobUpdateAction enum. Not married to the labels 
> I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
> finer-grained actions. 
> 
> 
> Diffs
> -----
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
> 
> Diff: https://reviews.apache.org/r/24720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Reply via email to