> On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 538
> > <https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538>
> >
> >     What action is going to be used for an instance that failed to update 
> > and the job rollback is disabled?
> 
> David McLaughlin wrote:
>     Sounds like we need another state for this. Do you have a suggestion? 
> INSTANCE_UPDATE_FAILED ?
> 
> Bill Farner wrote:
>     INSTANCE_UPDATE_FAILED SGTM
> 
> Bill Farner wrote:
>     And FWIW disabled rollback isn't the only case for this.  It can happen 
> any time max_failed_instances > 0.

Do we need a separate INSTANCE_ROLLBACK_FAILED state to set apart a rollback 
failure? Otherwise, we may see two actions in the log: one from a forward 
failure and another one from a rollback failure.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24720/#review50805
-----------------------------------------------------------


On Aug. 15, 2014, 5:52 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24720/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2014, 5:52 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added some more items to the JobUpdateAction enum. Not married to the labels 
> I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into 
> finer-grained actions. 
> 
> 
> Expected actions:
> 
> 1) instance update: INSTANCE_UPDATED
> 2) instance remove: INSTANCE_REMOVED
> 3) instance add: INSTANCE_ADDED -> INSTANCE_UPDATING -> INSTANCE_UPDATED
> 4) noop: INSTANCE_SKIPPED
> 5) instance rolled back: INSTANCE_ROLLED_BACK
> 
> 
> Diffs
> -----
> 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> af9f02ed1de487bc5cc2967d2edcece5b21e0be5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  f695b85514bcc5cedb16e962124af3db052cb17a 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 21a05f6939da1dd7fc15cf6336bc3fee283f16ab 
> 
> Diff: https://reviews.apache.org/r/24720/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Reply via email to