At the moment, there's two end-to-end tests: test_end_to_end.sh, and
test_end_to_end_v2.sh. Since this is the v1 test, it should use v1.

     -Mark


On Wed, Sep 3, 2014 at 2:05 PM, Joe Smith <yasumo...@gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25206/
>
> On September 2nd, 2014, 6:47 p.m. PDT, *Joe Smith* wrote:
>
>   src/test/sh/org/apache/aurora/e2e/test_run.sh
> <https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23> 
> (Diff
> revision 1)
>
> 23
>
> aurora_command=${3:-"aurora run"}
>
>   aurora job run?
>
>  On September 2nd, 2014, 8:15 p.m. PDT, *Joe Smith* wrote:
>
> Kevin and Toby, can you two take a look at this ASAP? I'd like to have the 
> e2e tests fixed before I ship https://reviews.apache.org/r/25208/
>
>  On September 3rd, 2014, 9:25 a.m. PDT, *Joshua Cohen* wrote:
>
> It defaults to 'aurora run', for the aurora1 client, but we pass in 'aurora2 
> job run' from the test_end_to_end_v2.sh script. Are you saying to switch the 
> default (or maybe I should just remove the default altogether)?
>
>  I was saying switch the default so it's the new syntax
>
>
> - Joe
>
> On August 29th, 2014, 4:17 p.m. PDT, Joshua Cohen wrote:
>   Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias
> Weingartner.
> By Joshua Cohen.
>
> *Updated Aug. 29, 2014, 4:17 p.m.*
>  *Bugs: * AURORA-676 <https://issues.apache.org/jira/browse/AURORA-676>
>  *Repository: * aurora
> Description
>
> Fix aurora run in end to end tests.
>
>   Testing
>
> $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
> Unfortunately the v2 client end to end tests are currently broken (filed 
> https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
> test for aurora task run works in that script as well.
>
>   Diffs
>
>    - examples/vagrant/upstart/mesos-slave.conf
>    (e53d545f3a66383c12ed1e7de6b1eef2dbad1541)
>    - src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>    (fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f)
>    - src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
>    (14a0b62c1b06179211d79f35a9c6df162c9a5999)
>    - src/test/sh/org/apache/aurora/e2e/test_run.sh (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/25206/diff/>
>

Reply via email to