----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52210 -----------------------------------------------------------
Ship it! examples/vagrant/upstart/mesos-slave.conf <https://reviews.apache.org/r/25206/#comment90955> Can you add a comment explaining why this is necessary (preferably with a link to a bug where we will fix this in the client - the clusters.json default should match the mesos default). - Kevin Sweeney On Aug. 29, 2014, 4:17 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25206/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2014, 4:17 p.m.) > > > Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias > Weingartner. > > > Bugs: AURORA-676 > https://issues.apache.org/jira/browse/AURORA-676 > > > Repository: aurora > > > Description > ------- > > Fix aurora run in end to end tests. > > > Diffs > ----- > > examples/vagrant/upstart/mesos-slave.conf > e53d545f3a66383c12ed1e7de6b1eef2dbad1541 > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > 14a0b62c1b06179211d79f35a9c6df162c9a5999 > src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/25206/diff/ > > > Testing > ------- > > $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > Unfortunately the v2 client end to end tests are currently broken (filed > https://issues.apache.org/jira/browse/AURORA-677), but I verified that the > test for aurora task run works in that script as well. > > > Thanks, > > Joshua Cohen > >