----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52389 -----------------------------------------------------------
\m/ src/main/python/apache/aurora/executor/common/health_checker.py <https://reviews.apache.org/r/25337/#comment91170> make _healthy and _reason non-private src/main/python/apache/aurora/executor/common/health_checker.py <https://reviews.apache.org/r/25337/#comment91171> super(HealthChecker, self).start() src/main/python/apache/aurora/executor/common/health_checker.py <https://reviews.apache.org/r/25337/#comment91172> think you'll need an extra newline here for checkstyle to not complain src/test/python/apache/aurora/executor/common/test_health_checker.py <https://reviews.apache.org/r/25337/#comment91174> please obtain an ephemeral port here instead. who is to say that port 9001 is not running a service that accepts the health check protocol? or at the very least, create a mock HttpSignaler src/test/python/apache/aurora/executor/common/test_health_checker.py <https://reviews.apache.org/r/25337/#comment91175> all of these attributes should likely be public or read-only properties of private attributes src/test/python/apache/aurora/executor/common/test_health_checker.py <https://reviews.apache.org/r/25337/#comment91173> the + is superfluous src/test/python/apache/aurora/executor/test_thermos_executor.py <https://reviews.apache.org/r/25337/#comment91176> derp? - Brian Wickman On Sept. 5, 2014, 12:43 a.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25337/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 12:43 a.m.) > > > Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian > Wickman. > > > Bugs: AURORA-682 > https://issues.apache.org/jira/browse/AURORA-682 > > > Repository: aurora > > > Description > ------- > > Preserve executor HealthCheckerThread name > > > Diffs > ----- > > src/main/python/apache/aurora/executor/common/health_checker.py > 603fff35b839c6f53d9379ec047d7d8135a1c65b > src/test/python/apache/aurora/executor/common/BUILD > 3229facf40070929adabb57fef667ab11bf3d1ec > src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION > src/test/python/apache/aurora/executor/common/test_health_checker.py > 490d4c8b5c434f9d6f032d931e35c483b3a5b676 > src/test/python/apache/aurora/executor/common/test_task_info.py > 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 > > Diff: https://reviews.apache.org/r/25337/diff/ > > > Testing > ------- > > ###STILL RUNNING E2E TESTS > > [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ > ./build-support/python/isort-run > [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ > ./build-support/python/checkstyle-check > [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants > ./src/test/python/apache/aurora/executor:all > src.test.python.apache.aurora.executor.common.announcer > ..... SUCCESS > src.test.python.apache.aurora.executor.common.directory_sandbox > ..... SUCCESS > src.test.python.apache.aurora.executor.common.executor_timeout > ..... SUCCESS > src.test.python.apache.aurora.executor.common.health_checker > ..... SUCCESS > src.test.python.apache.aurora.executor.common.status_checker > ..... SUCCESS > src.test.python.apache.aurora.executor.common.task_info > ..... SUCCESS > src.test.python.apache.aurora.executor.executor_base > ..... SUCCESS > src.test.python.apache.aurora.executor.executor_detector > ..... SUCCESS > src.test.python.apache.aurora.executor.executor_vars > ..... SUCCESS > src.test.python.apache.aurora.executor.gc_executor > ..... SUCCESS > src.test.python.apache.aurora.executor.status_manager > ..... SUCCESS > src.test.python.apache.aurora.executor.thermos_executor > ..... SUCCESS > src.test.python.apache.aurora.executor.thermos_task_runner > ..... SUCCESS > > > Thanks, > > Joe Smith > >
