> On Sept. 4, 2014, 6:23 p.m., David Robinson wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 
> > 60
> > <https://reviews.apache.org/r/25337/diff/3/?file=679164#file679164line60>
> >
> >     Why do you need to cast num_calls?

leftover from the previous test (I believe), thanks


> On Sept. 4, 2014, 6:23 p.m., David Robinson wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, lines 28-30
> > <https://reviews.apache.org/r/25337/diff/3/?file=679161#file679161line28>
> >
> >     Docstring, one variable per line so the style is consistent, and 
> > perhaps change the order so it's consistent with HealthChecker()? eg, s/ 
> > initial_interval_secs, interval_secs/ interval_secs, initial_interval_secs/ 
> > and update the caller to match.

Let me know if this is what you had in mind!


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52395
-----------------------------------------------------------


On Sept. 4, 2014, 8 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 8 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-682
>     https://issues.apache.org/jira/browse/AURORA-682
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Preserve executor HealthCheckerThread name
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 603fff35b839c6f53d9379ec047d7d8135a1c65b 
>   src/test/python/apache/aurora/executor/common/BUILD 
> 3229facf40070929adabb57fef667ab11bf3d1ec 
>   src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> 490d4c8b5c434f9d6f032d931e35c483b3a5b676 
>   src/test/python/apache/aurora/executor/common/test_task_info.py 
> 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 
> 
> Diff: https://reviews.apache.org/r/25337/diff/
> 
> 
> Testing
> -------
> 
> ###STILL RUNNING E2E TESTS
> 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
> ./build-support/python/isort-run 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
> ./build-support/python/checkstyle-check 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants 
> ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer                       
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox               
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout                
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker                  
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker                  
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.common.task_info                       
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.executor_base                          
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.executor_detector                      
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.executor_vars                          
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.gc_executor                            
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.status_manager                         
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor                       
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner                    
>   .....   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Reply via email to