----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52661 -----------------------------------------------------------
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js <https://reviews.apache.org/r/25259/#comment91561> This seems to be too short to make any visual difference but could be a perf hit. How about 10-15sec instead? Also, is there any visual cue that the progress is auto-updated? src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js <https://reviews.apache.org/r/25259/#comment91567> Same here. src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js <https://reviews.apache.org/r/25259/#comment91570> Should not this be ROLL BACK PAUSED instead? src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html <https://reviews.apache.org/r/25259/#comment91554> Missing period. src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html <https://reviews.apache.org/r/25259/#comment91555> s/Instances/Instance src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html <https://reviews.apache.org/r/25259/#comment91553> Missing period. src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html <https://reviews.apache.org/r/25259/#comment91548> s/to watch to watch/to watch Just realized it's copied from api.thrift. Mind fixing it there as well? src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html <https://reviews.apache.org/r/25259/#comment91551> Suggest renaming to "Min Waiting Time In Running" to better reflect on the setting. src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html <https://reviews.apache.org/r/25259/#comment91552> s/set/subset? Also, suggest adding: "All instances will be affected if this is not set." - Maxim Khutornenko On Sept. 9, 2014, 1:05 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25259/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 1:05 a.m.) > > > Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-614 > https://issues.apache.org/jira/browse/AURORA-614 > > > Repository: aurora > > > Description > ------- > > Adds update history to the job page. Adds an update details page. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > de49a1c5497e32ee4db944412e5c87807c742d3c > src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html > c780b0fe98863b5421824a9652a7202da9f4302a > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css > 2a752313cb8ae404605a9458b33237a911eec061 > src/main/resources/org/apache/aurora/scheduler/http/ui/job.html > e21dee015897eee62ade8f74e26f042b8e2be734 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js > fb3b5b12121a6e8a30dbf6fe069557f69a563408 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js > 3477b7e667459665af9d9dc9d2456793822bc7f7 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js > 7f05a552f3786adb115ff9648f4fadce968230e9 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js > df2806481fc1c2f263d3afd9b21247e97a18ed57 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js > bfd360de45c75441743c8ba24a5c445f4146dba6 > src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html > PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/http/ui/update.html > PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html > PRE-CREATION > > Diff: https://reviews.apache.org/r/25259/diff/ > > > Testing > ------- > > ./gradlew jsHint > > > File Attachments > ---------------- > > job page > > https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png > update page > > https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png > > > Thanks, > > David McLaughlin > >
