> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, 
> > line 277
> > <https://reviews.apache.org/r/25259/diff/1/?file=683446#file683446line277>
> >
> >     This seems to be too short to make any visual difference but could be a 
> > perf hit. How about 10-15sec instead?
> >     
> >     Also, is there any visual cue that the progress is auto-updated?
> 
> Maxim Khutornenko wrote:
>     Also, will the auto-update get suspended when the page is out of focus 
> (e.g. user switches to another tab or hides the browser)? Would be great if 
> it does.
> 
> David McLaughlin wrote:
>     No visual cue that it's auto-updated. It could be something to add in the 
> future, or do you see it as a blocker for this? I picked 3s off the top of my 
> head. 10s sounds like a good alternative. 
>     
>     
>     Auto-update being suspended when the page is out of focus doesn't seem 
> like a desired feature. When I come back to the tab the page is always in the 
> same state as I last saw it. There is definitely a use case of tabbing in and 
> out to see how an update is going.
> 
> Maxim Khutornenko wrote:
>     | When I come back to the tab the page is always in the same state as I 
> last saw it.
>     Is it possible to suspend auto-update on lost focus and resume on 
> re-acquiring it? Not sure if there is a high level event available for it but 
> would be great to avoid wasted expensive queries on the scheduler if no one 
> is watching the page.

The problem with tabs/windows is they can be inactive but still visible in your 
screen. e.g. there's no way to know if the inactive window is hidden behind 
another window or still visible on a second screen.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, 
> > line 411
> > <https://reviews.apache.org/r/25259/diff/1/?file=683446#file683446line411>
> >
> >     Same here.

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 31
> > <https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line31>
> >
> >     Missing period.

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 32
> > <https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line32>
> >
> >     s/Instances/Instance

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 41
> > <https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line41>
> >
> >     Missing period.

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 61
> > <https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line61>
> >
> >     s/to watch to watch/to watch
> >     
> >     Just realized it's copied from api.thrift. Mind fixing it there as well?

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 62
> > <https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line62>
> >
> >     Suggest renaming to "Min Waiting Time In Running" to better reflect on 
> > the setting.

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 81
> > <https://reviews.apache.org/r/25259/diff/1/?file=683452#file683452line81>
> >
> >     s/set/subset?
> >     
> >     Also, suggest adding: "All instances will be affected if this is not 
> > set."

Fixed.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/#review52661
-----------------------------------------------------------


On Sept. 9, 2014, 11:32 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25259/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 11:32 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-614
>     https://issues.apache.org/jira/browse/AURORA-614
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adds update history to the job page. Adds an update details page. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> de49a1c5497e32ee4db944412e5c87807c742d3c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 
> c780b0fe98863b5421824a9652a7202da9f4302a 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
> 2a752313cb8ae404605a9458b33237a911eec061 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
> e21dee015897eee62ade8f74e26f042b8e2be734 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
> fb3b5b12121a6e8a30dbf6fe069557f69a563408 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> 3477b7e667459665af9d9dc9d2456793822bc7f7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> 7f05a552f3786adb115ff9648f4fadce968230e9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> df2806481fc1c2f263d3afd9b21247e97a18ed57 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> bfd360de45c75441743c8ba24a5c445f4146dba6 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/update.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html 
> PRE-CREATION 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 2b376d663b3bc9264965db58ef89de59b10169ad 
> 
> Diff: https://reviews.apache.org/r/25259/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew jsHint
> 
> 
> File Attachments
> ----------------
> 
> job page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png
> update page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Reply via email to