> On Sept. 9, 2014, 4:45 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java, > > line 53 > > <https://reviews.apache.org/r/25398/diff/3/?file=682822#file682822line53> > > > > Consider using the mock throughout. You get a little extra bit of > > verification that it is not invoked.
Updated. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/#review52735 ----------------------------------------------------------- On Sept. 9, 2014, 4:54 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25398/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 4:54 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-313 > https://issues.apache.org/jira/browse/AURORA-313 > > > Repository: aurora > > > Description > ------- > > Make the offer hold jitter window configurable. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > 5a38a1f69ac5dbe68af3bfe175899ddee392880b > > src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25398/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Joshua Cohen > >
