----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review53061 -----------------------------------------------------------
Aha, i thought you wanted this done down in JobUpdateController, so i put the validation in there. I'm happy to remove it from my diff. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/25481/#comment92450> I believe this will not surface nicely to the user, but will instead present as an internal error (based on LoggingInterceptor, which handles uncaught exceptions). - Bill Farner On Sept. 9, 2014, 7:46 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25481/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 7:46 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-649 > https://issues.apache.org/jira/browse/AURORA-649 > > > Repository: aurora > > > Description > ------- > > Adding JobUpdateRequest validation. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > a43e5d7748c22d60f56f03a8a3d52949faebeff2 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 0d51f7dc367081f72090736e36605bf363f3395e > > Diff: https://reviews.apache.org/r/25481/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > >
