> On Sept. 11, 2014, 6:13 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 1371 > > <https://reviews.apache.org/r/25481/diff/1/?file=684118#file684118line1371> > > > > I'm a little unfamilar with JobUpdateRequest and this RPC but it seems > > we should update "StartJobUpdateResult" to have a message field that we can > > surface to the user?
Messages are already sent via thrift Response object. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review53073 ----------------------------------------------------------- On Sept. 9, 2014, 7:46 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25481/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 7:46 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-649 > https://issues.apache.org/jira/browse/AURORA-649 > > > Repository: aurora > > > Description > ------- > > Adding JobUpdateRequest validation. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > a43e5d7748c22d60f56f03a8a3d52949faebeff2 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 0d51f7dc367081f72090736e36605bf363f3395e > > Diff: https://reviews.apache.org/r/25481/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > >
