> On Sept. 12, 2014, 10:09 a.m., Joe Smith wrote: > > src/test/python/apache/aurora/client/cli/test_task_run.py, line 228 > > <https://reviews.apache.org/r/25582/diff/1/?file=687672#file687672line228> > > > > "Test the ssh command for proper behavior when no tasks are found > > within a job" or something, I think > > Joshua Cohen wrote: > I'd go so far as to suggest that docstrings on test methods are probably > not necessary. This exemplifies why, they just get copied/pasted from other > tests and end up not accurately describing what each test does. I'd vote for > descriptive test case names and do away with docstrings entirely. > > David McLaughlin wrote: > +1
Yeah, that's probably the right move overall, though I'm okay with docstrings for test methods if they give a bit more clarification as opposed to increasing an already-long test-method name. - Joe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25582/#review53184 ----------------------------------------------------------- On Sept. 12, 2014, 10:17 a.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25582/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 10:17 a.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: aurora-706 > https://issues.apache.org/jira/browse/aurora-706 > > > Repository: aurora > > > Description > ------- > > Fix error in client "task ssh" command when the job isn't found. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/task.py > 91175facdc8ccccc9fd59ab66781f86ee8b5940a > src/main/python/apache/aurora/client/commands/ssh.py > 37a90089b72b86c82466f1819e7881a36bb2f214 > src/test/python/apache/aurora/client/cli/test_task_run.py > 8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b > src/test/python/apache/aurora/client/commands/test_ssh.py > 4070b710b005c91fe08dd7906cd93bf3a8cdba9e > > Diff: https://reviews.apache.org/r/25582/diff/ > > > Testing > ------- > > Added new tests to catch this case; > Ran all client unit tests, all tests pass. > > > Thanks, > > Mark Chu-Carroll > >
