> On Sept. 12, 2014, 11:47 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js, line > > 54 > > <https://reviews.apache.org/r/25259/diff/5/?file=688116#file688116line54> > > > > I'd like to see the paused states disambiguated. I could imagine a > > user resuming an update and being surprised by the direction the update > > moves.
Fixed. > On Sept. 12, 2014, 11:47 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line > > 338 > > <https://reviews.apache.org/r/25259/diff/5/?file=688117#file688117line338> > > > > TODO(davmclau) Dropped this from the UI, so just removed this entirely. > On Sept. 12, 2014, 11:47 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html, > > line 17 > > <https://reviews.apache.org/r/25259/diff/5/?file=688118#file688118line17> > > > > I'd love to see UTC here as well. I added it as a tooltip, so when you mouseover the time it will show you the UTC version. Do you think that's good enough or would you rather it just be visible at all times? > On Sept. 12, 2014, 11:47 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/update.html, line 24 > > <https://reviews.apache.org/r/25259/diff/5/?file=688119#file688119line24> > > > > Is the indenting off here? Fixed. Unfortunately my text editor does not play well with custom angular directives so I have to maintain this all manually. > On Sept. 12, 2014, 11:47 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/update.html, line 129 > > <https://reviews.apache.org/r/25259/diff/5/?file=688119#file688119line129> > > > > For my own edification - is there a pattern being followed w.r.t. > > newlines here? I thought i had the style figured out until here. Not really, at this point it's more of an art form. This particular example (and the indentation problem above) was a result of me removing the event timeline from the DOM and not going back and fixing everything. Fixed it now. Happy to open a ticket to investigate HTML linting if there is sufficient interest. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53244 ----------------------------------------------------------- On Sept. 12, 2014, 10:39 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25259/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 10:39 p.m.) > > > Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-614 > https://issues.apache.org/jira/browse/AURORA-614 > > > Repository: aurora > > > Description > ------- > > Adds update history to the job page. Adds an update details page. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > de49a1c5497e32ee4db944412e5c87807c742d3c > src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html > c780b0fe98863b5421824a9652a7202da9f4302a > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css > 2a752313cb8ae404605a9458b33237a911eec061 > src/main/resources/org/apache/aurora/scheduler/http/ui/job.html > e21dee015897eee62ade8f74e26f042b8e2be734 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js > fb3b5b12121a6e8a30dbf6fe069557f69a563408 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js > 3477b7e667459665af9d9dc9d2456793822bc7f7 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js > 7f05a552f3786adb115ff9648f4fadce968230e9 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js > df2806481fc1c2f263d3afd9b21247e97a18ed57 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js > bfd360de45c75441743c8ba24a5c445f4146dba6 > src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html > PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/http/ui/update.html > PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html > PRE-CREATION > src/main/thrift/org/apache/aurora/gen/api.thrift > 2b376d663b3bc9264965db58ef89de59b10169ad > > Diff: https://reviews.apache.org/r/25259/diff/ > > > Testing > ------- > > ./gradlew jsHint > > > File Attachments > ---------------- > > job page > > https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png > update page > > https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png > > > Thanks, > > David McLaughlin > >
