> On Sept. 16, 2014, 6:12 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, > > line 41 > > <https://reviews.apache.org/r/25259/diff/9/?file=690739#file690739line41> > > > > "...forward roll." - this is no longer correct as we use this setting > > for both forward and back roll. Mind updating this and api.thrift?
Done. Can you confirm you're okay with the updated description? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53555 ----------------------------------------------------------- On Sept. 16, 2014, 6:29 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25259/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 6:29 p.m.) > > > Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-614 > https://issues.apache.org/jira/browse/AURORA-614 > > > Repository: aurora > > > Description > ------- > > Adds update history to the job page. Adds an update details page. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 0336a6e00a9a7e14125eaae271788faaae0bd371 > src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html > c780b0fe98863b5421824a9652a7202da9f4302a > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css > 2a752313cb8ae404605a9458b33237a911eec061 > src/main/resources/org/apache/aurora/scheduler/http/ui/job.html > e21dee015897eee62ade8f74e26f042b8e2be734 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js > fb3b5b12121a6e8a30dbf6fe069557f69a563408 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js > 3477b7e667459665af9d9dc9d2456793822bc7f7 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js > 7f05a552f3786adb115ff9648f4fadce968230e9 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js > 76f48f8aa2399c83fbafe8efcf6f4f3e47ab05a0 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js > e898f12a7b6c6c35b4bce5a8aa78f3fcaa83a6df > src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html > PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/http/ui/update.html > PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html > PRE-CREATION > src/main/thrift/org/apache/aurora/gen/api.thrift > a6dc548c804bfcb9166573496023bad80b2a2c91 > > Diff: https://reviews.apache.org/r/25259/diff/ > > > Testing > ------- > > ./gradlew jsHint > > > File Attachments > ---------------- > > job page > > https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png > update page > > https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png > > > Thanks, > > David McLaughlin > >
