> On Oct. 10, 2014, 2:43 p.m., Joshua Cohen wrote: > > This task is getting somewhat complex, do you think it makes sense to > > externalize it[1], rather than having build.gradle take on more and more > > logic? > > > > [1] http://www.gradle.org/docs/current/userguide/custom_tasks.html > > Bill Farner wrote: > Thanks for the nudge, this crossed my mind as well. Left as a TODO for a > rainy day to unblock for now.
+1, I'd also like to nail down the story for sanely managing our build configuration. I've also got a custom PMD rule that I'd like to figure out how to wire in https://gist.github.com/kevints/3638383e1b10f1081c44, but that looks to be as difficult as writing it was. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26574/#review56227 ----------------------------------------------------------- On Oct. 10, 2014, 2:51 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26574/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 2:51 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-822 > https://issues.apache.org/jira/browse/AURORA-822 > > > Repository: aurora > > > Description > ------- > > `javac` inserts synthetic zero-arg constructors into anonymous classes, which > jacoco sometimes detects as covered by tests. This was throwing off the > "each class must have _some_ coverage" by considering classes without > coverage to actually have some coverage. > > I've attempted to fix this by ignoring the default constructor in anonymoous > classes, which should be more accurate. One sign that this is working — lots > of modules came onto the radar as lacking coverage, which is legitimate. > > > Diffs > ----- > > build.gradle 8f7eed0b58a00f8e5e0521512975087d5788b5b6 > > Diff: https://reviews.apache.org/r/26574/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > I also verified that i can now cherry-pick the patch from > https://reviews.apache.org/r/26469/ and produce a green build. On master, i > consistently get a coverage error. > > > Thanks, > > Bill Farner > >
