> On Oct. 21, 2014, 3:32 p.m., Joshua Cohen wrote: > > Thoughts on adding an 'all' component to aurorabuild.sh that builds > > everything? We do this in three places now that I know of (these two and > > the provision script). > > Maxim Khutornenko wrote: > That's exactly what I was hesitating on but decided in favor of an > explicit approach to make it completely obvious what is affected in every > case. Also, a minor (though temporary) speedup of not building unrelated > client version for every test path.
+1 to an 'all' target - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/#review57690 ----------------------------------------------------------- On Oct. 21, 2014, 3:29 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26998/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 3:29 p.m.) > > > Review request for Aurora, Joshua Cohen and Kevin Sweeney. > > > Bugs: AURORA-498 > https://issues.apache.org/jira/browse/AURORA-498 > > > Repository: aurora > > > Description > ------- > > Building aurora client/admin before running e2 tests. > > > Diffs > ----- > > src/test/sh/org/apache/aurora/e2e/test_common.sh > 43d2516133c6d6cdb4236358f942396f057f739c > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > 324aa4dbeff00e673fe73b87e3a0766856cd213c > src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 > > Diff: https://reviews.apache.org/r/26998/diff/ > > > Testing > ------- > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh > > > Thanks, > > Maxim Khutornenko > >
