----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review58294 -----------------------------------------------------------
Master (53f4e73) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.api.api ..... SUCCESS src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS src.test.python.apache.aurora.client.api.mux ..... SUCCESS src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS src.test.python.apache.aurora.client.api.restarter ..... SUCCESS src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS src.test.python.apache.aurora.client.api.sla ..... SUCCESS src.test.python.apache.aurora.client.api.updater ..... SUCCESS src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS src.test.python.apache.aurora.client.binding_helper ..... SUCCESS src.test.python.apache.aurora.client.cli.api ..... SUCCESS src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS src.test.python.apache.aurora.client.cli.cron ..... SUCCESS src.test.python.apache.aurora.client.cli.help ..... SUCCESS src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS src.test.python.apache.aurora.client.cli.job ..... FAILURE src.test.python.apache.aurora.client.config ..... SUCCESS - Aurora ReviewBot On Oct. 24, 2014, 2:50 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22457/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 2:50 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Brian Wickman. > > > Bugs: aurora-520 > https://issues.apache.org/jira/browse/aurora-520 > > > Repository: aurora > > > Description > ------- > > Add a new diff method, which uses field-by-field comparison of JSON trees for > comparing running job configurations to potentially updated configs. > > - Allow exclusion of semantically irrelevant fields. > - Provide a clearer list of the differences between configs. > - Provide a scripting-friendly alternative JSON syntax for diffs. > > The old diff behavior is still available under the "--use-shell-diff" option. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/BUILD > 995570325bbb09ecbcc2ace5d223760c5d49367f > src/main/python/apache/aurora/client/cli/jobs.py > 625cb80a33ae565b403fc71bb9795e4700e1aeb7 > src/main/python/apache/aurora/client/cli/json_tree_diff.py PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > 4692d31a9c128664273f71d15ee217dc060e66f0 > src/test/python/apache/aurora/client/cli/test_diff.py > 78694d7559f2041f27cd2a7e4cb81ca467f63ac2 > src/test/python/apache/aurora/client/cli/test_json_diff.py PRE-CREATION > > Diff: https://reviews.apache.org/r/22457/diff/ > > > Testing > ------- > > New unit tests of the JSON tree diff code, plus a bunch of new "job diff" > tests of the new functionality. > All tests pass. > > > Thanks, > > Mark Chu-Carroll > >
