> On Nov. 5, 2014, 2:19 a.m., Maxim Khutornenko wrote:
> > src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java,
> >  line 164
> > <https://reviews.apache.org/r/27542/diff/1/?file=747813#file747813line164>
> >
> >     duplicate asserts

Nope, this is two calls to mutateTasks, both return values being checked.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/#review59918
-----------------------------------------------------------


On Nov. 3, 2014, 10:11 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27542/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 10:11 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Bring WriteAheadStorage up to 100% branch and instruction coverage.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> cbab75964052a950e1b868b3a53eb15fadb31cb7 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
> 094d1c66e1f464687e0416bc652dba4b1bda0f7e 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27542/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to