> On Nov. 5, 2014, 8:24 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java, > > line 172 > > <https://reviews.apache.org/r/27542/diff/2/?file=750495#file750495line172> > > > > Note: none of these annotations will work since we're constructing this > > class without Guice.
I'll just remove them, fixing is out of scope for this review. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27542/#review60024 ----------------------------------------------------------- On Nov. 5, 2014, 6:04 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27542/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 6:04 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Bring WriteAheadStorage up to 100% branch and instruction coverage. > > > Diffs > ----- > > config/pmd/logging-java.xml e4ec6adffdb88d35de3f5001d79e94befa44d067 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > cbab75964052a950e1b868b3a53eb15fadb31cb7 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > 094d1c66e1f464687e0416bc652dba4b1bda0f7e > > src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/27542/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
