-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review61387
-----------------------------------------------------------


This patch does not apply cleanly on master (316f291), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 14, 2014, 1:30 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28026/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 1:30 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This brings SchedulerThriftInterface to 99% instruction coverage and 96% 
> branch coverage.  The remaining pieces are legitimately difficult to capture.
> 
> I also uncovered a few minor bugs along the way, most noteworthy being AOP 
> interceptor ordering leading to the standard API response not always being 
> applied.
> 
> Additionally, i removed a bunch of unnecessary exception handling that is now 
> done by an AOP interceptor.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f202969906113ccb610bf17c94d188c43 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b2b66acee9c0789f3660469d6d504b4510af5e79 
>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
> 18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> dca855c522d21924821fc47e636da39689aec4b7 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/28026/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to