-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/
-----------------------------------------------------------
(Updated Nov. 19, 2014, 11:05 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: AURORA-937
https://issues.apache.org/jira/browse/AURORA-937
Repository: aurora
Description
-------
This brings SchedulerThriftInterface to 99% instruction coverage and 96% branch
coverage. The remaining pieces are legitimately difficult to capture.
I also uncovered a few minor bugs along the way, most noteworthy being AOP
interceptor ordering leading to the standard API response not always being
applied.
Additionally, i removed a bunch of unnecessary exception handling that is now
done by an AOP interceptor.
Diffs (updated)
-----
src/main/java/org/apache/aurora/auth/SessionValidator.java
eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc
src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java
4744dc9f202969906113ccb610bf17c94d188c43
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
4b65a2ccb32ff5058c5b7adb858c5225c16784c6
src/main/java/org/apache/aurora/scheduler/thrift/Util.java
18e2bdfab6406761d7e7cbcec26d12fb28441fe0
src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java
dca855c522d21924821fc47e636da39689aec4b7
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
608903268a0a0d67711bfdc81d2e5b29c335ead2
Diff: https://reviews.apache.org/r/28026/diff/
Testing
-------
Thanks,
Bill Farner
