-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28103/#review61678
-----------------------------------------------------------
Master (8741cdb) is red with this patch.
./build-support/jenkins/build.sh
+ date
Sun Nov 16 01:30:01 UTC 2014
+ ./gradlew -Pq clean build
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean
:bootstrapThrift
:checkPython
:generateSources
:compileGeneratedJavaNote: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:processGeneratedResources UP-TO-DATE
:generatedClasses
:compileJavaNote: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
:processResources
:classes
:jar
:assemble
:jsHint
:checkstyleMain[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java:35:1:
Utility classes should not have a public or default constructor.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java:111:18:
'(' is followed by whitespace.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 29.951 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Nov. 16, 2014, 1:22 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28103/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2014, 1:22 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Simplify Preemptor code, encapsulate fields used there and in
> SchedulingFilter.
>
> A lot of this addressing Law of Demeter violations, such as accepting
> `IAssignedTask` when only `ITaskConfig` and task ID were needed. There are
> also (what i consider) readability improvements in `SchedulingFilterImpl` and
> `PreemptorImpl`.
>
> The broader goal here is to simplify the code usedin scheduling, hopefully to
> make forthcoming scheduling performance improvements less complicated.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/Preemptor.java
> ff26c49729646ffe052cb0a993b9984ae96a89ac
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java
> 6bfa3ac425ed3045fa60d1b0ca547e9bf3cde37a
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java
> a2997f518f90eac34cb6fbb1104240b823d45f22
>
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
> 8cf845f3622392a65216e0c29084965c7c64075d
>
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
> ca53303a675be60300cc1b6534164fa6da7ddbd7
> src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java
> 3839083f27ca5d4b93406152559b58b04e912a10
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java
> c1c5f26723f1eac3000e09e061b4582f922fded6
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java
> cc6b53b3265253f76c1e954c0108aa5936f5cc36
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java
> 4abc7ba36c547624af51fabc0983099efe5798ea
> src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java
> 79d12b0dd7959b5443ffce43d9ebdb79135718bb
> src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java
> 8b0367ec99701084ce0cf55229a363c4b0b66b8f
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java
> 9bc6a7535bf69dbc19771aa1834aeb04f42eea48
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java
> d1bc9bfe987b83356483cf1fb04aef2eb51eb141
>
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
> 94f0a179b786649775899f855f7c1a0caab7290f
>
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
> e113eba1f304279b5ee3d70db1d1ea558efd63ac
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
> a8a70b65c6f91371b9afad4dd3806a7c86fba04f
>
> Diff: https://reviews.apache.org/r/28103/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
