> On Nov. 25, 2014, 8:49 p.m., Kevin Sweeney wrote:
> > examples/docker/Dockerfile, lines 14-16
> > <https://reviews.apache.org/r/28198/diff/4/?file=776032#file776032line14>
> >
> >     Can we avoid the extra clone here and build from the currently checked 
> > out repo? That way this script is likely to stay maintained in the future 
> > and might even make it into our development workflow.
> >     
> >     If that's not possible then as far as I know this sha has no special 
> > significance, maybe replace it with a download of the 0.6.0 release?

What do you mean by the currently checked out repo? do you mean head?

I just picked that sha because it's the one before my change. I was thinking of 
using 0.6.0 but there was no tag, I can use "0.6.0-rc0" branch if that works.


> On Nov. 25, 2014, 8:49 p.m., Kevin Sweeney wrote:
> > examples/docker/Dockerfile, line 34
> > <https://reviews.apache.org/r/28198/diff/4/?file=776032#file776032line34>
> >
> >     Should we also add the upstart configs from the vagrant example to the 
> > container? How about documentation for running - can I do something similar 
> > to vagrant up and get a full cluster-in-a-box?

I'm still in the process of getting a cluster-in-a-box running, so far I've 
just been copying the pex and libs out into my existing machine. I haven't 
really prioritized figuring out how to run everything from the docker 
container, it's something I'll work on in the future.


- Tony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review63040
-----------------------------------------------------------


On Nov. 25, 2014, 7:47 p.m., Tony Dong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28198/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2014, 7:47 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an example on how to build with Docker.
> 
> 
> Diffs
> -----
> 
>   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
>   examples/docker/Dockerfile PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28198/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Dong
> 
>

Reply via email to