> On Nov. 25, 2014, 1:27 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/common/test_transport.py, line 89
> > <https://reviews.apache.org/r/28451/diff/1/?file=776097#file776097line89>
> >
> >     You can remove the lambda here if you unset instance=True on session.

The underlying code will raise an exception if I don't pass in a callable that 
returns session.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28451/#review63044
-----------------------------------------------------------


On Nov. 25, 2014, 1:22 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28451/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2014, 1:22 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-949
>     https://issues.apache.org/jira/browse/AURORA-949
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This changes TRequestsTransport to raise an exception on 4xx or 5xx 
> responses. Previously the TRequestsTransport would ignore those responses and 
> treat the response as valid. The response would not be valid JSON and cause 
> thrift decoding errors later on.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/common/transport.py 
> 6f7c355d725b5e537cc4ae471170eaa8431da326 
>   src/test/python/apache/aurora/common/test_transport.py 
> c722eae2d04dec90e9c772f49c578184a2bdf76c 
> 
> Diff: https://reviews.apache.org/r/28451/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/common:test_transport -v
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to