----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/#review63065 -----------------------------------------------------------
Ship it! Master (91b8d19) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 25, 2014, 10:51 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28451/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 10:51 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-949 > https://issues.apache.org/jira/browse/AURORA-949 > > > Repository: aurora > > > Description > ------- > > This changes TRequestsTransport to raise an exception on 4xx or 5xx > responses. Previously the TRequestsTransport would ignore those responses and > treat the response as valid. The response would not be valid JSON and cause > thrift decoding errors later on. > > > Diffs > ----- > > src/main/python/apache/aurora/common/transport.py > 6f7c355d725b5e537cc4ae471170eaa8431da326 > src/test/python/apache/aurora/common/test_transport.py > c722eae2d04dec90e9c772f49c578184a2bdf76c > > Diff: https://reviews.apache.org/r/28451/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/common:test_transport -v > > > Thanks, > > Zameer Manji > >