----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/#review63587 -----------------------------------------------------------
src/main/python/apache/aurora/executor/aurora_executor.py <https://reviews.apache.org/r/28486/#comment105861> task sanitation shouldn't be the responsibility of the sandbox manager. instead on L99 we should add something like: try: mesos_task_instance_from_assigned_task(assigned_task) except ValueError as e: self._die(driver, mesos_pb2.TASK_FAILED, 'Invalid task: %s' % e) return - Brian Wickman On Dec. 2, 2014, 2:14 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28486/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 2:14 a.m.) > > > Review request for Aurora, Kevin Sweeney and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > Sandbox initialization is an operation that might fail and raise an exception. > By moving this into the try block the executor will return TASK_FAILED > instead of crashing when an exception is raised. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/aurora_executor.py > 79a24855b2a68271b7478395dfdadab8755c3af2 > src/main/python/apache/aurora/executor/common/sandbox.py > f47a32b3fefb4a89940b1ddc473b8316ac00df12 > src/test/python/apache/aurora/executor/BUILD > 4d43e256ad131223cc1ac36a406d42a979a8a2dd > src/test/python/apache/aurora/executor/test_aurora_executor.py PRE-CREATION > > Diff: https://reviews.apache.org/r/28486/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/executor:: > > > Thanks, > > Zameer Manji > >
