----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/#review63453 -----------------------------------------------------------
src/main/python/apache/aurora/executor/aurora_executor.py <https://reviews.apache.org/r/28486/#comment105708> This makes the code inconsistent with line 141: ```` except self._sandbox.Error as e: ```` I would prefer to remain consistent with the existing code. - Zameer Manji On Dec. 1, 2014, 2:24 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28486/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2014, 2:24 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Repository: aurora > > > Description > ------- > > Sandbox initialization is an operation that might fail and raise an exception. > By moving this into the try block the executor will return TASK_FAILED > instead of crashing when an exception is raised. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/aurora_executor.py > 79a24855b2a68271b7478395dfdadab8755c3af2 > src/main/python/apache/aurora/executor/common/sandbox.py > f47a32b3fefb4a89940b1ddc473b8316ac00df12 > src/test/python/apache/aurora/executor/BUILD > 4d43e256ad131223cc1ac36a406d42a979a8a2dd > src/test/python/apache/aurora/executor/test_aurora_executor.py PRE-CREATION > > Diff: https://reviews.apache.org/r/28486/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/executor:: > > > Thanks, > > Zameer Manji > >
