> On Dec. 4, 2014, 9:21 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, lines 172-175 > > <https://reviews.apache.org/r/28693/diff/1/?file=782496#file782496line172> > > > > Why not keeping @abstractmethod attributes and dropping the return > > statements instead? With your modification there is no need to keep this > > noop behavior as tests like "EmptyPlugin" below would not be possible > > anyway.
The return statements provide default behaviour that plugins should have to prevent AURORA-362. If get_options does not return an iterable the argument handling code will crash and before_dispatch needs to return raw_args to prevent the clobbering of user passed in commandline arguments. This reduces the work that plugins need to do if they are just interested in implementing before_execution or after_execution. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28693/#review63859 ----------------------------------------------------------- On Dec. 3, 2014, 10:36 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28693/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 10:36 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > This makes ConfigurationPlugin inherit from AbstractClass so the > @abstractmethod annotation is useful. This also removes the annotation for > the two methods with default values. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > 6e553d8af459e575b2d62282a3bc0d1e266203d8 > src/test/python/apache/aurora/client/cli/test_plugins.py > 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a > > Diff: https://reviews.apache.org/r/28693/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client:: > > > Thanks, > > Zameer Manji > >
