----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28693/#review63870 -----------------------------------------------------------
Ship it! Ship It! - Maxim Khutornenko On Dec. 4, 2014, 6:14 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28693/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 6:14 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > This makes ConfigurationPlugin inherit from AbstractClass so the > @abstractmethod annotation is useful. This also removes the annotation for > the two methods with default values. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > 6e553d8af459e575b2d62282a3bc0d1e266203d8 > src/test/python/apache/aurora/client/cli/test_plugins.py > 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a > > Diff: https://reviews.apache.org/r/28693/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client:: > > > Thanks, > > Zameer Manji > >
