----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29015/#review65117 -----------------------------------------------------------
The changes look good to me. Can you please update the testing portion of the ticket with the actual outout from a vagrant session? - Zameer Manji On Dec. 12, 2014, 4:40 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29015/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 4:40 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-968 > https://issues.apache.org/jira/browse/AURORA-968 > > > Repository: aurora > > > Description > ------- > > Problems addressed: > - Duplicate output due to relying on both `context.print_err()` and `raise > CommandError` > - Duplicate output in case of missing err_msg in `check_and_log_response()` > - Inconsistent messaging and error handling cases > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/context.py > b1ffc05ebd520e91be58704615c5a12c62e75f03 > src/main/python/apache/aurora/client/cli/cron.py > 1f1efdb47eaf09af84813ae1af210c5ebdde7d0c > src/main/python/apache/aurora/client/cli/jobs.py > 8bdb7f488f68b10b767ced627e55e57698e4f5f2 > src/main/python/apache/aurora/client/cli/quota.py > 137aab1285a9732a3b65aee65948e836df3c7cac > src/main/python/apache/aurora/client/cli/task.py > a70f908de63904f9d3bd3776f60432d9329931e7 > src/main/python/apache/aurora/client/cli/update.py > d1d0b2946c0513381345d90fabe22c1b7c6b8ca9 > src/test/python/apache/aurora/client/cli/test_create.py > 9aaf82a485e2c517848ad7e0b2fc41efa017bbbd > src/test/python/apache/aurora/client/cli/test_kill.py > 3036f9cdf9e4805229664e64445fec5ec222be8e > src/test/python/apache/aurora/client/cli/test_quota.py > 202cc45ffa7efb5b5268bf41ca14104504735478 > src/test/python/apache/aurora/client/cli/test_restart.py > c19b21dd99dded0fdc631cef90997e2f2bd1156e > src/test/python/apache/aurora/client/cli/test_supdate.py > eafb909098e6f757db1522d5cb605ff04a96e8b6 > src/test/python/apache/aurora/client/cli/test_update.py > 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 > src/test/python/apache/aurora/client/cli/util.py > 6dba1855f8951d38882c0d5b01a5a609b774d00f > > Diff: https://reviews.apache.org/r/29015/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client/cli:all > Also, visually verified in vagrant. > > > Thanks, > > Maxim Khutornenko > >
