-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29015/
-----------------------------------------------------------
(Updated Jan. 7, 2015, 10:13 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Rebased.
Bugs: AURORA-968
https://issues.apache.org/jira/browse/AURORA-968
Repository: aurora
Description
-------
Problems addressed:
- Duplicate output due to relying on both `context.print_err()` and `raise
CommandError`
- Duplicate output in case of missing err_msg in `check_and_log_response()`
- Inconsistent messaging and error handling cases
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/context.py
f062afc8de1769f6796fc307107c61a59e9366c5
src/main/python/apache/aurora/client/cli/cron.py
1f1efdb47eaf09af84813ae1af210c5ebdde7d0c
src/main/python/apache/aurora/client/cli/jobs.py
744d53405081e75b9aedcdcb7e4a823a2e0e743f
src/main/python/apache/aurora/client/cli/quota.py
137aab1285a9732a3b65aee65948e836df3c7cac
src/main/python/apache/aurora/client/cli/task.py
a70f908de63904f9d3bd3776f60432d9329931e7
src/main/python/apache/aurora/client/cli/update.py
d1d0b2946c0513381345d90fabe22c1b7c6b8ca9
src/test/python/apache/aurora/client/cli/test_create.py
9aaf82a485e2c517848ad7e0b2fc41efa017bbbd
src/test/python/apache/aurora/client/cli/test_kill.py
3036f9cdf9e4805229664e64445fec5ec222be8e
src/test/python/apache/aurora/client/cli/test_quota.py
202cc45ffa7efb5b5268bf41ca14104504735478
src/test/python/apache/aurora/client/cli/test_restart.py
1653ae2a2c8ef527c24003e77c5eee9c18428322
src/test/python/apache/aurora/client/cli/test_supdate.py
eafb909098e6f757db1522d5cb605ff04a96e8b6
src/test/python/apache/aurora/client/cli/test_update.py
561dd96739ee951b9d5c0ef82d725d515528850b
src/test/python/apache/aurora/client/cli/util.py
6dba1855f8951d38882c0d5b01a5a609b774d00f
Diff: https://reviews.apache.org/r/29015/diff/
Testing
-------
./pants src/test/python/apache/aurora/client/cli:all
Also, visually verified in vagrant:
Before:
vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall
devcluster/www-data/prod/hello
INFO] Checking status of devcluster/www-data/prod/hello
INFO]
INFO] Killing tasks for job: devcluster/www-data/prod/hello
INFO] Instances to be killed: [0]
Tasks were not killed in time.
Kill of shards [0] failed with error:
Exceeded maximum number of errors while killing instances
Error executing command: Exceeded maximum number of errors while killing
instances
After:
vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall
devcluster/www-data/prod/hello
INFO] Checking status of devcluster/www-data/prod/hello
INFO]
INFO] Killing tasks for job: devcluster/www-data/prod/hello
INFO] Instances to be killed: [0]
Instances [0] were not killed in time
Error executing command: Exceeded maximum number of errors while killing
instances
Thanks,
Maxim Khutornenko
