> On Dec. 17, 2014, 11:18 a.m., Kevin Sweeney wrote: > > src/test/python/apache/aurora/executor/test_executor_vars.py, line 34 > > <https://reviews.apache.org/r/29171/diff/1/?file=794969#file794969line34> > > > > Can this test above be removed? > > Brian Wickman wrote: > should I just remove all tag exporting from the executor_vars? I think > they're unused, plus likely twitter specific.
+1 to that, discard this diff in favor of an upstream patch - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29171/#review65350 ----------------------------------------------------------- On Dec. 17, 2014, 11:16 a.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29171/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 11:16 a.m.) > > > Review request for Aurora and Joe Smith. > > > Repository: aurora > > > Description > ------- > > Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO. > > > Diffs > ----- > > src/test/python/apache/aurora/executor/BUILD > 3095f2a148b21365ea2f500039adb5710a187fa1 > src/test/python/apache/aurora/executor/test_executor_vars.py > af1c7b7d78b89ae713d6db96cf766b596fa91c55 > > Diff: https://reviews.apache.org/r/29171/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/executor:executor_vars -v > > > Thanks, > > Brian Wickman > >
