-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review66935
-----------------------------------------------------------


Thanks for the patch!  Most of my comments are style-related, but i think a 
bunch of the python changes are unneeded.


api/src/main/thrift/org/apache/thermos/thermos_internal.thrift
<https://reviews.apache.org/r/29464/#comment110733>

    AFAICT this value is not really used for anything meaningful, and no 
changes should be made in the runner code.  I followed this value, and it is 
plumbed into 
`src/main/python/apache/thermos/observer/http/templates/rawtask.tpl`, just a 
title HTML tag.



src/main/java/org/apache/aurora/scheduler/app/AppModule.java
<https://reviews.apache.org/r/29464/#comment110666>

    These were already out of order before your patch, but please make sure 
that field declaration, arguments, and assignment are all in the same order.



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
<https://reviews.apache.org/r/29464/#comment110716>

    please add a class javadoc



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
<https://reviews.apache.org/r/29464/#comment110718>

    style nit - we format wrapped method signatures as:
    
    ```
    public LocalServiceRegistryWithOverrides(
        LocalServiceRegistry registry,
        Settings settings) {
    ```



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
<https://reviews.apache.org/r/29464/#comment110719>

    requireNonNull



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
<https://reviews.apache.org/r/29464/#comment110720>

    Indented too far - should be +4 from previous line



src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
<https://reviews.apache.org/r/29464/#comment110721>

    remove @Nullable



src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java
<https://reviews.apache.org/r/29464/#comment110724>

    When wrapping a long argument list, break out each argument on its own line.



src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java
<https://reviews.apache.org/r/29464/#comment110725>

    Ditto re: signature wrapping style



src/main/python/apache/aurora/executor/common/announcer.py
<https://reviews.apache.org/r/29464/#comment110735>

    I assume this is effectively picking up the `--hostname` command line 
argument from the slave, is that correct?  If so, please include a comment here 
about why we do that rather than calling `socket.gethostname()`.



src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
<https://reviews.apache.org/r/29464/#comment110727>

    Can you use an actual mock instead of the fake?



src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
<https://reviews.apache.org/r/29464/#comment110726>

    Indent style should be:
    
    ```
    return new A(
        arg1,
        arg2);



src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java
<https://reviews.apache.org/r/29464/#comment110730>

    expand this into arg-per-line



src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java
<https://reviews.apache.org/r/29464/#comment110731>

    pull this up to the previous line.  intellij likes to do this particular 
auto-refactor.


- Bill Farner


On Jan. 6, 2015, 10:45 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29464/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 10:45 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I've added a new flag for the aurora scheduler, -hostname which can override 
> the scheduler server address published into ZK.
> 
> This is useful for cases such as running the scheduler in EC2, where the 
> autodetected local address is actual an interal IP and not the public address 
> of the machine.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
>   
> src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> cf173850635572c0df38bdd5cb14de8ce2016bf7 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/bin/thermos_runner.py 
> 647de2771f301b17de33d8b45198c211d2e84367 
>   src/main/python/apache/thermos/core/runner.py 
> 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   
> src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> e329a90b8fba43611f5120e2a5ee82220dbe2a91 
> 
> Diff: https://reviews.apache.org/r/29464/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Reply via email to