> On Jan. 8, 2015, 2:20 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/app/AppModule.java, line 96
> > <https://reviews.apache.org/r/29464/diff/8/?file=809079#file809079line96>
> >
> >     requireNonNull

I didn't add this (I just reordered the parameters), so I'm hesitant to change 
it.


> On Jan. 8, 2015, 2:20 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java,
> >  line 83
> > <https://reviews.apache.org/r/29464/diff/8/?file=809080#file809080line83>
> >
> >     im not sure why this needs to be synchronized? holding an intrinsic 
> > lock while calling out to another class is prone to deadlocks and I don't 
> > see any mutable state being protected.

Good catch, I think this was an artifact of some previous refactoring.


> On Jan. 8, 2015, 2:20 a.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/executor/thermos_task_runner.py, line 76
> > <https://reviews.apache.org/r/29464/diff/8/?file=809084#file809084line76>
> >
> >     Can we drop the default here or make it lazy? Otherwise importing this 
> > module has the side-effect of making a syscall.

That's how I had this origionally but I changed it based on [feedback 
above](#review66428).  You're going to get a syscall regardless though.


> On Jan. 8, 2015, 2:20 a.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/executor/thermos_task_runner.py, line 101
> > <https://reviews.apache.org/r/29464/diff/8/?file=809084#file809084line101>
> >
> >     convention here would seem to be to make hostname default to None and 
> > do hostname or socket.gethostname() here.

Same as above.  I'll change it back...


- Steve


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review67136
-----------------------------------------------------------


On Jan. 7, 2015, 9:21 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29464/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 9:21 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I've added a new flag for the aurora scheduler, -hostname which can override 
> the scheduler server address published into ZK.
> 
> This is useful for cases such as running the scheduler in EC2, where the 
> autodetected local address is actual an interal IP and not the public address 
> of the machine.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
>   
> src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> cf173850635572c0df38bdd5cb14de8ce2016bf7 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/bin/thermos_runner.py 
> 647de2771f301b17de33d8b45198c211d2e84367 
>   src/main/python/apache/thermos/core/runner.py 
> 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   
> src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> e329a90b8fba43611f5120e2a5ee82220dbe2a91 
> 
> Diff: https://reviews.apache.org/r/29464/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Reply via email to