> On Jan. 14, 2015, 7:21 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/cli/context.py, line 214 > > <https://reviews.apache.org/r/29873/diff/1/?file=820320#file820320line214> > > > > Seems like it would make sense for this to be the default behavior of > > `get_job_status`. I can't imagine why the default should be to fetch the > > active tasks plus some arbitrary history (since history is pruned) of dead > > instances. > > > > Meta: we should ~always do filtering like this server-side if possible. > > In this case, you should pass ACTIVE_STATES as a query parameter. > > `get_status_for_jobs` is also guilty of this, but would benefit from the > > proposd default behavior of `get_job_status` as well. > > Maxim Khutornenko wrote: > The get_job_status is used by "aurora job status" to pull all available > instances (including terminal ones). > > I was split between using a pre- and post- query filters and decided for > the latter as a simpler one. The perf gain is quite neglible given the > limited history we persist but I am happy to reconsider if you think it's > worth it.
I'm pretty strongly in favor of filtering with the query. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/#review68078 ----------------------------------------------------------- On Jan. 14, 2015, 1:16 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29873/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 1:16 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-996 > https://issues.apache.org/jira/browse/AURORA-996 > > > Repository: aurora > > > Description > ------- > > Fixed job status quering in client context to return active tasks where > needed. > > Also, dropped active instance validation from both updater calls as it was > hiding a legitimate feature: add new job instances with instance_spec. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/context.py > 93587c616afb0b7493a509197361cd76af2e2c97 > src/main/python/apache/aurora/client/cli/jobs.py > 508c9be556998e47bddcec8dee43f1595497b354 > src/main/python/apache/aurora/client/cli/update.py > a1617325f08ca252bdba38618aef141504ba7272 > src/test/python/apache/aurora/client/cli/test_kill.py > b475d737ede8ff0a669a9a9229196a76b43b46b6 > src/test/python/apache/aurora/client/cli/test_restart.py > a532ead256869c620e6bd96886ce9681b3423d0c > > Diff: https://reviews.apache.org/r/29873/diff/ > > > Testing > ------- > > ./pants src/test/python:all > > vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall > devcluster/www-data/prod/hello > INFO] Checking status of devcluster/www-data/prod/hello > INFO] > No tasks to kill found for job devcluster/www-data/prod/hello > Job killall succeeded > > > Thanks, > > Maxim Khutornenko > >
