-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29873/
-----------------------------------------------------------
(Updated Jan. 15, 2015, 7:44 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Bill's comments.
Bugs: AURORA-996
https://issues.apache.org/jira/browse/AURORA-996
Repository: aurora
Description
-------
Fixed job status quering in client context to return active tasks where needed.
Also, dropped active instance validation from both updater calls as it was
hiding a legitimate feature: add new job instances with instance_spec.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/__init__.py
64f08046f6aca112a9f51c3f250ba6102d297216
src/main/python/apache/aurora/client/cli/context.py
93587c616afb0b7493a509197361cd76af2e2c97
src/main/python/apache/aurora/client/cli/jobs.py
508c9be556998e47bddcec8dee43f1595497b354
src/main/python/apache/aurora/client/cli/task.py
21548984f6f5cd894733220c6508458cc1318391
src/main/python/apache/aurora/client/cli/update.py
a1617325f08ca252bdba38618aef141504ba7272
src/test/python/apache/aurora/client/cli/test_command_hooks.py
e8432a1f3475e7e48a092526998d15cbf7e92e10
src/test/python/apache/aurora/client/cli/test_create.py
18b58383d209a50bd09fbdfa5a600e49d1d848f7
src/test/python/apache/aurora/client/cli/test_kill.py
b475d737ede8ff0a669a9a9229196a76b43b46b6
src/test/python/apache/aurora/client/cli/test_plugins.py
aa45851bd26f78583e0c16d0c3699c12f8a58697
src/test/python/apache/aurora/client/cli/test_restart.py
a532ead256869c620e6bd96886ce9681b3423d0c
src/test/python/apache/aurora/client/cli/test_supdate.py
9378b49ec5e4bb8189b00d9fd1d80558a731d668
src/test/python/apache/aurora/client/cli/test_update.py
c12b32e3327af8c014fdad72d63ab4e68dc541c8
src/test/python/apache/aurora/client/cli/util.py
147d418ea1de679674dd93eaf648d84686b95d37
Diff: https://reviews.apache.org/r/29873/diff/
Testing
-------
./pants src/test/python:all
vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall
devcluster/www-data/prod/hello
INFO] Checking status of devcluster/www-data/prod/hello
INFO]
No tasks to kill found for job devcluster/www-data/prod/hello
Job killall succeeded
Thanks,
Maxim Khutornenko